On Wed 16-08-17 00:01:08, Chen Yu wrote: > Hi Michal, > On Tue, Aug 15, 2017 at 02:41:19PM +0200, Michal Hocko wrote: [...] > > Moreover why don't you need to touch_nmi_watchdog in the loop over all > > pfns in the zone (right above this loop)? > As the NMI was triggered when checking the free_list rather than in the loop over > all pfns, it seems that the former has more possibility to catch a NMI if the > latter has already taken too much time. But yes, a safer way is to feed dog > in the latter too. I'll modify the code according to your suggestion. This is a wrong approach IMHO. The whole thing has IRQ disabled. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
