On Mon, 2011-01-03 at 16:10 +0200, Pekka Enberg wrote: > > correct incorrect % Function File Line > > ------- --------- - -------- ---- ---- > > 6890998 2784830 28 slab_alloc slub.c 1719 > > > > That's incorrect 28% of the time. > > Thanks! AFAICT, that number is high enough to justify removing the > unlikely() annotations, no? Personally, I think anything that is incorrect more that 5% of the time should not have any annotation. My rule is to use the annotation when a branch goes one way 95% or more. With the exception of times when we want a particular path to be the faster path, because we know its in a more critical position (as there are cases in the scheduler and the tracing infrastructure itself). But here, I think removing it is the right decision. -- Steve -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>