On Wed 14-06-17 17:12:06, Wei Yang wrote: > On Wed, Jun 14, 2017 at 08:32:06AM +0200, Michal Hocko wrote: > >On Wed 14-06-17 14:12:59, Wei Yang wrote: > >[...] > >> Hi, Michal > >> > >> Not sure you missed this one or you think this is fine. > >> > >> Hmm... this will not happen since we must offline a whole memory_block? > > > >yes > > > >> So the memory_hotplug/unplug unit is memory_block instead of mem_section? > > > >yes. > > If this is true, the check_hotplug_memory_range() should be fixed too. as I've said earlier. There are many code paths which are quite confusing and they expect sub-section granularity while they in fact won't work with sub memblock granularity. This is a larger project I am afraid and it would be great if you are willing to try to consolidate that code. I have that on my todo list but there are more pressing things to address first for me now. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>