On Wed, Dec 08, 2010 at 12:01:26AM +0900, Minchan Kim wrote: > del_page_from_lru_list alreay called mem_cgroup_del_lru. > So we need to call it again. It makes wrong stat of memcg and > even happen VM_BUG_ON hit. > > Cc: Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > Cc: Mel Gorman <mel@xxxxxxxxx> > Signed-off-by: Minchan Kim <minchan.kim@xxxxxxxxx> > --- > mm/compaction.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 50b0a90..b0fbfdf 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -302,7 +302,6 @@ static unsigned long isolate_migratepages(struct zone *zone, > /* Successfully isolated */ > del_page_from_lru_list(zone, page, page_lru(page)); > list_add(&page->lru, migratelist); > - mem_cgroup_del_lru(page); > cc->nr_migratepages++; > nr_isolated++; > > -- > 1.7.0.4 > Hi Andrew, Please drop above(mm-compactionc-avoid-double-mem_cgroup_del_lru.patch) This is a new version with modified description and added Acked-by. >From 64b3a2c1205d3ffc55878ab8f00f4d450318bb91 Mon Sep 17 00:00:00 2001 From: Minchan Kim <minchan.kim@xxxxxxxxx> Date: Thu, 9 Dec 2010 23:49:27 +0900 Subject: [PATCH] mm/compaction.c: avoid double mem_cgroup_del_lru() del_page_from_lru_list() already called mem_cgroup_del_lru(). So we must not call it again. It adds unnecessary overhead. Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> Acked-by: Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> Acked-by: Mel Gorman <mel@xxxxxxxxx> Reviewed-by: Johannes Weiner <hannes@xxxxxxxxxxx> Signed-off-by: Minchan Kim <minchan.kim@xxxxxxxxx> --- mm/compaction.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 50b0a90..b0fbfdf 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -302,7 +302,6 @@ static unsigned long isolate_migratepages(struct zone *zone, /* Successfully isolated */ del_page_from_lru_list(zone, page, page_lru(page)); list_add(&page->lru, migratelist); - mem_cgroup_del_lru(page); cc->nr_migratepages++; nr_isolated++; -- 1.7.0.4 -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>