On Thu, Dec 9, 2010 at 1:43 AM, Johannes Weiner <hannes@xxxxxxxxxxx> wrote: > On Wed, Dec 08, 2010 at 12:01:26AM +0900, Minchan Kim wrote: >> del_page_from_lru_list alreay called mem_cgroup_del_lru. >> So we need to call it again. It makes wrong stat of memcg and >> even happen VM_BUG_ON hit. >> >> Cc: Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> >> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> >> Cc: Mel Gorman <mel@xxxxxxxxx> >> Signed-off-by: Minchan Kim <minchan.kim@xxxxxxxxx> > > Reviewed-by: Johannes Weiner <hannes@xxxxxxxxxxx> > > But regarding the severity of this: shouldn't the second deletion > attempt be caught by the TestClearPageCgroupAcctLRU() early in > mem_cgroup_del_lru_list()? > Right, I missed that. Andrew, I will resend modified description. Thanks for careful review again, Hannes. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>