* Dmitry Vyukov <dvyukov@xxxxxxxxxx> wrote: > On Fri, Mar 24, 2017 at 11:57 AM, Ingo Molnar <mingo@xxxxxxxxxx> wrote: > > > > * Dmitry Vyukov <dvyukov@xxxxxxxxxx> wrote: > > > >> > Are just utterly disgusting that turn perfectly readable code into an > >> > unreadable, unmaintainable mess. > >> > > >> > You need to find some better, cleaner solution please, or convince me that no > >> > such solution is possible. NAK for the time being. > >> > >> Well, I can just write all functions as is. Does it better confirm to kernel > >> style? > > > > I think writing the prototypes out as-is, properly organized, beats any of these > > macro based solutions. > > You mean write out the prototypes, but use what for definitions? Macros again? No, regular C code. I don't see the point of generating all this code via CPP - it's certainly not making it more readable to me. I.e. this patch I commented on is a step backwards for readability. I'd prefer repetition and a higher overall line count over complex CPP constructs. Thanks, Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
