On 03/03/2017 08:31 AM, Minchan Kim wrote: > On Thu, Mar 02, 2017 at 07:57:10PM +0530, Anshuman Khandual wrote: >> On 03/02/2017 12:09 PM, Minchan Kim wrote: >>> SWAP_SUCCESS defined value 0 can be changed always so don't rely on >>> it. Instead, use explict macro. >> >> Right. But should not we move the changes to the callers last in the >> patch series after doing the cleanup to the try_to_unmap() function >> as intended first. > > I don't understand what you are pointing out. Could you elaborate it > a bit? I was just referring to the order of this patch in the series and thinking if it would have been better if this patch would be at a later stage in the series. But I guess its okay as we are any way dropping off SWAP_FAIL, SWAP_SUCCESS etc in the end. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
