On Thu, Mar 02, 2017 at 07:57:10PM +0530, Anshuman Khandual wrote: > On 03/02/2017 12:09 PM, Minchan Kim wrote: > > SWAP_SUCCESS defined value 0 can be changed always so don't rely on > > it. Instead, use explict macro. > > Right. But should not we move the changes to the callers last in the > patch series after doing the cleanup to the try_to_unmap() function > as intended first. I don't understand what you are pointing out. Could you elaborate it a bit? Thanks. > > > > Cc: Kirill A. Shutemov <kirill@xxxxxxxxxxxxx> > > Signed-off-by: Minchan Kim <minchan@xxxxxxxxxx> > > --- > > mm/huge_memory.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > index 092cc5c..fe2ccd4 100644 > > --- a/mm/huge_memory.c > > +++ b/mm/huge_memory.c > > @@ -2114,7 +2114,7 @@ static void freeze_page(struct page *page) > > ttu_flags |= TTU_MIGRATION; > > > > ret = try_to_unmap(page, ttu_flags); > > - VM_BUG_ON_PAGE(ret, page); > > + VM_BUG_ON_PAGE(ret != SWAP_SUCCESS, page); > > } > > > > static void unfreeze_page(struct page *page) > > > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@xxxxxxxxx. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
