On Tue, 30 Nov 2010 17:15:37 +0900 Minchan Kim <minchan.kim@xxxxxxxxx> wrote: > Ideally, I hope we unify global and memcg of kswapd for easy > maintainance if it's not a big problem. > When we make patches about lru pages, we always have to consider what > I should do for memcg. > And when we review patches, we also should consider what the patch is > missing for memcg. > It makes maintainance cost big. Of course, if memcg maintainers is > involved with all patches, it's no problem as it is. > I know it's not. But thread control of kswapd will not have much merging point. And balance_pgdat() is fully replaced in patch/3. The effort for merging seems not big. > If it is impossible due to current kswapd's spaghetti, we can clean up > it first. I am not sure whether my suggestion make sense or not. make sense. > Kame can know it much rather than me. But please consider such the voice. Unifying is ok in general but this patch seems uglier than imagined. Implementing a simple memcg one and considering how-to-merge is a way. But it's a long way. For now. we have to check the design/function of patch before how beautiful it is. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>