On Wed 14-12-16 12:55:35, Dave Jiang wrote: > pmd_fault() and relate functions really only need the vmf parameter since > the additional parameters are all included in the vmf struct. Removing > additional parameter and simplify pmd_fault() and friends. > > Signed-off-by: Dave Jiang <dave.jiang@xxxxxxxxx> > Reviewed-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx> ... > diff --git a/fs/dax.c b/fs/dax.c > index 157f77f..66c8f2e 100644 > --- a/fs/dax.c > +++ b/fs/dax.c > @@ -1226,9 +1226,9 @@ EXPORT_SYMBOL_GPL(dax_iomap_fault); > */ > #define PG_PMD_COLOUR ((PMD_SIZE >> PAGE_SHIFT) - 1) > > -static int dax_pmd_insert_mapping(struct vm_area_struct *vma, pmd_t *pmd, > - struct vm_fault *vmf, unsigned long address, > - struct iomap *iomap, loff_t pos, bool write, void **entryp) > +static int dax_pmd_insert_mapping(struct vm_area_struct *vma, > + struct vm_fault *vmf, struct iomap *iomap, loff_t pos, > + bool write, void **entryp) Any reason for keeping 'vma' and 'write' arguments? They can be fetched from vmf as well... > -static int dax_pmd_load_hole(struct vm_area_struct *vma, pmd_t *pmd, > - struct vm_fault *vmf, unsigned long address, > +static int dax_pmd_load_hole(struct vm_area_struct *vma, struct vm_fault *vmf, > struct iomap *iomap, void **entryp) Ditto with vma here. Otherwise the patch looks good to me. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>