Hi Wu, On Mon, Nov 22, 2010 at 10:36 AM, Wu Fengguang <fengguang.wu@xxxxxxxxx> wrote: > On Sun, Nov 21, 2010 at 10:24:56PM +0800, Minchan Kim wrote: >> Now move_active_pages_to_lru can move pages into active or inactive. >> if it moves the pages into inactive, it itself can clear PG_acive. >> It makes the function more generic. > > Do you plan to use this "more generic" function? Because the patch in > itself makes code slightly less efficient. It adds one "if" test, and > moves one operation into the spin lock. I tried to use it in my deactivate page series but couldn't use it due some problem. So I don't have a plan to use it. It's just my preference(and I hope others think like me :) ) I hope function itself would be generic and clear because some people in future might use it and reference it. If my change makes big cost, I am not against you. otherwise, I hope move_active_pages_to_lru become self-contained. > > Thanks, > Fengguang > -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>