On Sun, Nov 21, 2010 at 10:24:56PM +0800, Minchan Kim wrote: > Now move_active_pages_to_lru can move pages into active or inactive. > if it moves the pages into inactive, it itself can clear PG_acive. > It makes the function more generic. Do you plan to use this "more generic" function? Because the patch in itself makes code slightly less efficient. It adds one "if" test, and moves one operation into the spin lock. Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>