Re: [PATCH 2/2] mm: add PageWaiters bit to indicate waitqueue should be checked

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 4, 2016 at 12:29 AM, Nicholas Piggin <npiggin@xxxxxxxxx> wrote:
> Oh, okay, the zone lookup. Well I am of the impression that most of the
> cache misses are coming from the waitqueue hash table itself.

No.

Nick, stop this idiocy.

NUMBERS, Nick. NUMBERS.

I posted numbers in "page_waitqueue() considered harmful" on linux-mm.

And quite frankly, before _you_ start posting numbers, that zone crap
IS NEVER COMING BACK.

What's so hard about this concept? We don't add crazy complexity
without numbers. Numbers that I bet you will not be able to provide,
because quiet frankly, even in your handwavy "what about lots of
concurrent IO from hundreds of threads" situation, that wait-queue
will NOT BE NOTICEABLE.

So no "impressions". No "what abouts". No "threaded IO" excuses. The
_only_ thing that matters is numbers. If you don't have them, don't
bother talking about that zone patch.

             Linus

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]