On Wed, Nov 2, 2016 at 1:03 AM, Nicholas Piggin <npiggin@xxxxxxxxx> wrote:
> + __wake_up_locked_key(q, TASK_NORMAL, &key);
> + if (!waitqueue_active(q) || !key.page_match) {
> + ClearPageWaiters(page);
Is that "page_match" optimization really worth it? I'd rather see
numbers for that particular optimization. I'd rather see the
contention bit being explicitly not precise.
Also, it would be lovely to get numbers against the plain 4.8
situation with the per-zone waitqueues. Maybe that used to help your
workload, so the 2.2% improvement might be partly due to me breaking
performance on your machine.
But other than that this all looks fine to me.
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>