[linux-stable-rc:linux-4.8.y 332/333] arch/arm64/include/asm/pgtable.h:36:28: warning: suggest parentheses around assignment used as truth value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.8.y
head:   402b64acb7a69a2c68ca579eef09eb0a82e4a267
commit: c6e27246850996584c694502958a3cf105df9256 [332/333] mm/hugetlb: check for reserved hugepages during memory offline
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout c6e27246850996584c694502958a3cf105df9256
        # save the attached .config to linux build tree
        make.cross ARCH=arm64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/mm.h:68:0,
                    from mm/hugetlb.c:7:
   mm/hugetlb.c: In function 'dissolve_free_huge_pages':
>> arch/arm64/include/asm/pgtable.h:36:28: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
    #define vmemmap   ((struct page *)VMEMMAP_START - (memstart_addr >> PAGE_SHIFT))
                               ^
   include/asm-generic/memory_model.h:53:29: note: in expansion of macro 'vmemmap'
    #define __pfn_to_page(pfn) (vmemmap + (pfn))
                                ^~~~~~~
   include/asm-generic/memory_model.h:81:21: note: in expansion of macro '__pfn_to_page'
    #define pfn_to_page __pfn_to_page
                        ^~~~~~~~~~~~~
   mm/hugetlb.c:1485:36: note: in expansion of macro 'pfn_to_page'
      if (rc = dissolve_free_huge_page(pfn_to_page(pfn)))
                                       ^~~~~~~~~~~

vim +36 arch/arm64/include/asm/pgtable.h

4f04d8f0 Catalin Marinas    2012-03-05  20  #include <asm/proc-fns.h>
4f04d8f0 Catalin Marinas    2012-03-05  21  
4f04d8f0 Catalin Marinas    2012-03-05  22  #include <asm/memory.h>
4f04d8f0 Catalin Marinas    2012-03-05  23  #include <asm/pgtable-hwdef.h>
3eca86e7 Mark Rutland       2016-02-26  24  #include <asm/pgtable-prot.h>
4f04d8f0 Catalin Marinas    2012-03-05  25  
4f04d8f0 Catalin Marinas    2012-03-05  26  /*
3e1907d5 Ard Biesheuvel     2016-03-30  27   * VMALLOC range.
08375198 Catalin Marinas    2014-07-16  28   *
f9040773 Ard Biesheuvel     2016-02-16  29   * VMALLOC_START: beginning of the kernel vmalloc space
3e1907d5 Ard Biesheuvel     2016-03-30  30   * VMALLOC_END: extends to the available space below vmmemmap, PCI I/O space
3e1907d5 Ard Biesheuvel     2016-03-30  31   *	and fixed mappings
4f04d8f0 Catalin Marinas    2012-03-05  32   */
f9040773 Ard Biesheuvel     2016-02-16  33  #define VMALLOC_START		(MODULES_END)
08375198 Catalin Marinas    2014-07-16  34  #define VMALLOC_END		(PAGE_OFFSET - PUD_SIZE - VMEMMAP_SIZE - SZ_64K)
4f04d8f0 Catalin Marinas    2012-03-05  35  
3bab79ed Ard Biesheuvel     2016-03-30 @36  #define vmemmap			((struct page *)VMEMMAP_START - (memstart_addr >> PAGE_SHIFT))
4f04d8f0 Catalin Marinas    2012-03-05  37  
d016bf7e Kirill A. Shutemov 2015-02-11  38  #define FIRST_USER_ADDRESS	0UL
4f04d8f0 Catalin Marinas    2012-03-05  39  
4f04d8f0 Catalin Marinas    2012-03-05  40  #ifndef __ASSEMBLY__
2f4b829c Catalin Marinas    2015-07-10  41  
961faac1 Mark Rutland       2016-01-25  42  #include <asm/fixmap.h>
2f4b829c Catalin Marinas    2015-07-10  43  #include <linux/mmdebug.h>
2f4b829c Catalin Marinas    2015-07-10  44  

:::::: The code at line 36 was first introduced by commit
:::::: 3bab79edc67152cb6cadb12773b7c7d05228eb77 Revert "arm64: account for sparsemem section alignment when choosing vmemmap offset"

:::::: TO: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
:::::: CC: Will Deacon <will.deacon@xxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]