> +static void _bdi_wakeup_flusher(struct backing_dev_info *bdi) Remove the leading underscore, please. > void bdi_start_background_writeback(struct backing_dev_info *bdi) > { > - __bdi_start_writeback(bdi, LONG_MAX, true, true); > + /* > + * We just wake up the flusher thread. It will perform background > + * writeback as soon as there is no other work to do. > + */ > + spin_lock_bh(&bdi->wb_lock); > + _bdi_wakeup_flusher(bdi); > + spin_unlock_bh(&bdi->wb_lock); We probably want a trace point here, too. Otherwise the patch looks good to me. Thanks for bringing it up again. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>