* Chris Metcalf <cmetcalf@xxxxxxxxxxxx> wrote:
> On 4/6/2016 2:58 AM, Ingo Molnar wrote:
> >* Hugh Dickins <hughd@xxxxxxxxxx> wrote:
> >
> >>--- a/arch/x86/include/asm/pgtable.h
> >>+++ b/arch/x86/include/asm/pgtable.h
> >>@@ -181,6 +181,7 @@ static inline int pmd_trans_huge(pmd_t p
> >> return (pmd_val(pmd) & (_PAGE_PSE|_PAGE_DEVMAP)) == _PAGE_PSE;
> >> }
> >>+#define has_transparent_hugepage has_transparent_hugepage
> >> static inline int has_transparent_hugepage(void)
> >> {
> >> return cpu_has_pse;
> >Small nit, just writing:
> >
> > #define has_transparent_hugepage
> >
> >ought to be enough, right?
>
> No, since then in hugepage_init() the has_transparent_hugepage() call site
> would be left with just a stray pair of parentheses instead of a call.
Yes, indeed ...
Thanks,
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>