On Wed, 20 Oct 2010 11:07:33 +0900 (JST) KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> wrote: > > > > @@ -5013,6 +5014,8 @@ int __meminit init_per_zone_wmark_min(void) > > > > min_free_kbytes = 128; > > > > if (min_free_kbytes > 65536) > > > > min_free_kbytes = 65536; > > > > + > > > > + refresh_zone_stat_thresholds(); > > > > setup_per_zone_wmarks(); > > > > setup_per_zone_lowmem_reserve(); > > > > setup_per_zone_inactive_ratio(); > > > > > > setup_per_zone_wmarks() could change the min and low watermarks for a zone > > > when refresh_zone_stat_thresholds() would have used the old value. > > > > Indeed. > > > > I could make the obvious fix, but then what I'd have wouldn't be > > sufficiently tested. > > Can we review this? It's unclear what you mean? The patches otherwise look OK to me, but it's pretty easy to make mistakes in this area. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>