On Thu 2016-02-25 13:36:41, Peter Zijlstra wrote: > On Mon, Feb 22, 2016 at 03:56:55PM +0100, Petr Mladek wrote: > > Also note that drain() correctly handles self-queuing works in compare > > with flush(). > > Nothing seems to prevent adding more work after drain() observes > list_empty(). You might want to drain() more times during the kthread worker life time to make sure that the work is done. The user is responsible for stopping any queuing when this function is called. The user usually needs to handle this anyway because producing a work that could not be queued would cause problems. To be honest, I wanted to keep the main principles of the API compatible with workqueues. It should reduce some potential confusion. Also it will make it easier to convert between the two APIs. IMHO, there are work loads when you are not sure if you will need a dedicated kthread when designing a new functionality. Best Regards, Petr -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>