On Fri, Feb 26, 2016 at 6:29 AM, Chen Gang <chengang@xxxxxxxxxxxxxxxx> wrote: > git is a tool mainly for analyzing code, but not mainly for normal > reading main code. > > So for me, the coding styles need not consider about git. For you, maybe yes. But for most of the developers/learners, git blame does help a lot. Kernel code was not as complicated as it is now, it is keeping evolving. So basically a history chain is indispensable in studying such a complex system. git blame fits in this role. I benefited a lot from using it when I started to learn the code, And, a pure coding style fix is sometimes really troublesome as I have to use git blame to go another step up along the history chain, which is time consuming and boring. But after all, I bet you will be fond of using it if you dive deeper into the kernel code studying. And if you do, you will know why so many developers in this thread are so upset and allergic to such coding-style fix. As for coding style, actually IMHO this patch is even _not_ a coding style, more like a code shuffle, indeed. And for your commit history, I found actually you have already contributed some quit good patches. I don't think it is helpful for a non-layman contributor to keep generating such code churn. Thanks, Jianyu Zhan -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>