[linux-next:master 1781/2084] fs/ocfs2/file.c:2198:1: warning: label 'relock' defined but not used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   888c8375131656144c1605071eab2eb6ac49abc3
commit: 1a46f12e507169712d013d2da8f8e06135281661 [1781/2084] ocfs2: code clean up for direct io
config: x86_64-randconfig-b0-01281432 (attached as .config)
reproduce:
        git checkout 1a46f12e507169712d013d2da8f8e06135281661
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   fs/ocfs2/file.c: In function 'ocfs2_file_write_iter':
>> fs/ocfs2/file.c:2198:1: warning: label 'relock' defined but not used [-Wunused-label]
    relock:
    ^

vim +/relock +2198 fs/ocfs2/file.c

faaebf18 Joseph Qi         2015-09-04  2182  	int append_write = ((iocb->ki_pos + count) >=
faaebf18 Joseph Qi         2015-09-04  2183  			i_size_read(inode) ? 1 : 0);
9517bac6 Mark Fasheh       2007-02-09  2184  
468eedde Tao Ma            2011-02-22  2185  	trace_ocfs2_file_aio_write(inode, file, file->f_path.dentry,
468eedde Tao Ma            2011-02-22  2186  		(unsigned long long)OCFS2_I(inode)->ip_blkno,
9517bac6 Mark Fasheh       2007-02-09  2187  		file->f_path.dentry->d_name.len,
468eedde Tao Ma            2011-02-22  2188  		file->f_path.dentry->d_name.name,
3ef045c3 Al Viro           2014-04-03  2189  		(unsigned int)from->nr_segs);	/* GRRRRR */
8659ac25 Tiger Yang        2006-10-17  2190  
66ee59af Christoph Hellwig 2015-02-11  2191  	if (count == 0)
8659ac25 Tiger Yang        2006-10-17  2192  		return 0;
8659ac25 Tiger Yang        2006-10-17  2193  
2ba48ce5 Al Viro           2015-04-09  2194  	direct_io = iocb->ki_flags & IOCB_DIRECT ? 1 : 0;
9517bac6 Mark Fasheh       2007-02-09  2195  
5955102c Al Viro           2016-01-22  2196  	inode_lock(inode);
9517bac6 Mark Fasheh       2007-02-09  2197  
9517bac6 Mark Fasheh       2007-02-09 @2198  relock:
7bdb0d18 Tristan Ye        2010-10-11  2199  	/*
7bdb0d18 Tristan Ye        2010-10-11  2200  	 * Concurrent O_DIRECT writes are allowed with
7bdb0d18 Tristan Ye        2010-10-11  2201  	 * mount_option "coherency=buffered".
faaebf18 Joseph Qi         2015-09-04  2202  	 * For append write, we must take rw EX.
7bdb0d18 Tristan Ye        2010-10-11  2203  	 */
faaebf18 Joseph Qi         2015-09-04  2204  	rw_level = (!direct_io || full_coherency || append_write);
7bdb0d18 Tristan Ye        2010-10-11  2205  
8659ac25 Tiger Yang        2006-10-17  2206  	ret = ocfs2_rw_lock(inode, rw_level);

:::::: The code at line 2198 was first introduced by commit
:::::: 9517bac6cc7a7aa4fee63cb38a32cb6014e264c7 ocfs2: teach ocfs2_file_aio_write() about sparse files

:::::: TO: Mark Fasheh <mark.fasheh@xxxxxxxxxx>
:::::: CC: Mark Fasheh <mark.fasheh@xxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]