On Fri, Jan 22, 2016 at 11:42 AM, Christian Borntraeger <borntraeger@xxxxxxxxxx> wrote: > > Just want to mention that this patch breaks older versions of valgrind > (including the current release) > https://bugs.kde.org/show_bug.cgi?id=357833 Ugh. Looks like valgrind is doing something that fundamentally can't be "tweaked" around in the algorithm. Setting the data limit to zero will never work with any model that starts accounting any mmap, so we can't just tweak things a bit.. > It is fixed in trunk (and even triggered some good cleanups, so the valgrind > developers do NOT want it to get reverted). Hmm. If we start getting complaints from users, I suspect we'll just have to revert. The fact that the valgrind developers are ok with the change doesn't much matter - all that matters is whether users are ok with it. The only saving grace is that valgrind is fairly specialized, so it's not like it breaks some core workflow. But I could easily see people who run valgrind as part of some regression suite having their day-to-day work broken. So I'll let it slide for now, but if I start seeing complaints, I think we'll just have to revert and wait for fixed valgrind versions to actually percolate out to people and re-do it later.. (The "percolate out to people" tends to take a _loong_ time, though). Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>