On 12/28/2015 11:22 PM, Linus Torvalds wrote: > On Mon, Dec 28, 2015 at 1:10 PM, Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote: >> Really sorry for delays. Konstantin, I slightly updated the >> changelog (to point where problem came from). Linus are you >> fine with accounting not only anonymous memory in VmData? > > The patch looks ok to me. I guess if somebody relies on old behavior > we may have to tweak it a bit, but on the whole this looks sane and > I'd be happy to merge it in the 4.5 merge window (and maybe even have > it marked for stable if it works out) > Just want to mention that this patch breaks older versions of valgrind (including the current release) https://bugs.kde.org/show_bug.cgi?id=357833 It is fixed in trunk (and even triggered some good cleanups, so the valgrind developers do NOT want it to get reverted). Rawhide already has the valgrind fix, others might not, so if we consider this for stable, things might break here and there, but in general this looks like a good cleanup. Christian -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>