* KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> [2010-10-07 08:58:58]: > On Wed, 6 Oct 2010 19:53:14 +0530 > Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote: > > > I propose restricting page_cgroup.flags to 16 bits. The patch for the > > same is below. Comments? > > > > > > Restrict the bits usage in page_cgroup.flags > > > > From: Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> > > > > Restricting the flags helps control growth of the flags unbound. > > Restriciting it to 16 bits gives us the possibility of merging > > cgroup id with flags (atomicity permitting) and saving a whole > > long word in page_cgroup > > > > Signed-off-by: Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> > > Doesn't make sense until you show the usage of existing bits. ?? > And I guess 16bit may be too large on 32bit systems. too large on 32 bit systems? My intention is to keep the flags to 16 bits and then use cgroup id for the rest and see if we can remove mem_cgroup pointer > Nack for now. > The issue is - do you see further growth of flags? > Thanks, > -Kame > -- Three Cheers, Balbir -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>