> > @@ -1349,6 +1350,7 @@ static int ext3_setup_super(struct super > > } else { > > ext3_msg(sb, KERN_INFO, "using internal journal"); > > } > > + sb->cleancache_poolid = cleancache_init_fs(PAGE_SIZE); > > Do you really need to pass in the page size? What about just > "cleancache_init_fs(sb)" rather than exposing the > "sb->cleancache_poolid"? In other words, what if you want to do > more/other per-filesystem init at some point? IIRC, I think I was trying to stay away from including fs.h in cleancache.h (or one of its predecessors). I agree that that no longer makes sense and it is cleaner as you suggest. Will change. Thanks, Dan -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href