On 08/30/2010 03:32 PM, Dan Magenheimer wrote:
> [PATCH V4 5/8] Cleancache: ext3 hook for cleancache
>
> Filesystems must explicitly enable cleancache by calling
> cleancache_init_fs anytime a instance of the filesystem
> is mounted and must save the returned poolid. For ext3,
> all other cleancache hooks are in the VFS layer including
> the matching cleancache_flush_fs hook which must be
> called on unmount.
>
> Signed-off-by: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>
> Acked-by: Andreas Dilger <adilger@xxxxxxx>
>
> Diffstat:
> super.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-2.6.36-rc3/fs/ext3/super.c 2010-08-29 09:36:04.000000000 -0600
> +++ linux-2.6.36-rc3-cleancache/fs/ext3/super.c 2010-08-30 09:20:42.000000000 -0600
> @@ -37,6 +37,7 @@
> #include <linux/quotaops.h>
> #include <linux/seq_file.h>
> #include <linux/log2.h>
> +#include <linux/cleancache.h>
>
> #include <asm/uaccess.h>
>
> @@ -1349,6 +1350,7 @@ static int ext3_setup_super(struct super
> } else {
> ext3_msg(sb, KERN_INFO, "using internal journal");
> }
> + sb->cleancache_poolid = cleancache_init_fs(PAGE_SIZE);
Do you really need to pass in the page size? What about just
"cleancache_init_fs(sb)" rather than exposing the
"sb->cleancache_poolid"? In other words, what if you want to do
more/other per-filesystem init at some point?
J
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>