Re: [S+Q 09/16] [percpu] make allocpercpu usable during early boot

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 28 Jun 2010, Pekka Enberg wrote:
> > +               return kzalloc(size, GFP_KERNEL & gfp_allowed_mask);
> >        else {
> >                void *ptr = vmalloc(size);
> >                if (ptr)
>
> This looks wrong to me. All slab allocators should do gfp_allowed_mask
> magic under the hood. Maybe it's triggering kmalloc_large() path that
> needs the masking too?

They do gfp_allowed_mask magic. But the checks at function entry of the
slabs do not mask the masks so we get false positives without this. All my
protest against the checks doing it this IMHO broken way were ignored.

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]