On 06/10, KAMEZAWA Hiroyuki wrote: > > > Afaics > > > > - task_in_mem_cgroup() should use find_lock_task_mm() too > > > > - oom_kill_process() should check "PF_EXITING && p->mm", > > like select_bad_process() does. > > > > Hm. I'd like to look into that when the next mmotm is shipped. > (too many pactches in flight..) Me too ;) > The problem is > > for (walking each 'process') > if (task_in_mem_cgroup(p, memcg)) > > can't check 'p' containes threads belongs to given memcg because p->mm can > be NULL. So, task_in_mem_cgroup should call find_lock_task_mm() when > getting "mm" struct. Yes, this is what I meant. And after we do this change we should tweak oom_kill_process() too, otherwise we have another problem. Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>