On 06/08, David Rientjes wrote: > > On Tue, 8 Jun 2010, Oleg Nesterov wrote: > > > > It's unnecessary to SIGKILL a task that is already PF_EXITING > > > > This probably needs some explanation. PF_EXITING doesn't necessarily > > mean this process is exiting. > > I hope that my sentence didn't imply that it was, the point is that > sending a SIGKILL to a PF_EXITING task isn't necessary to make it exit, > it's already along the right path. Well, probably this is right... David, currently I do not know how the code looks with all patches applied, could you please confirm there is no problem here? I am looking at Linus's tree, mem_cgroup_out_of_memory: p = select_bad_process(); oom_kill_process(p); Now, again, select_bad_process() can return the dead group-leader of the memory-hog-thread-group. In that case set_tsk_thread_flag(TIF_MEMDIE) buys nothing, this thread has aleady exited, but we do want to kill this process. If this is not true due to other changes - great. Otherwise, perhaps this needs - if (PF_EXITING) + if (PF_EXITING && mm) too? Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>