On Tue, 8 Jun 2010, Pekka Enberg wrote: > > An incremental patch in this case would change everything that the > > original patch did, so it'd probably be best to simply revert and queue > > the updated version. > > If I revert it, we end up with two commits instead of one. And I > really prefer not to *rebase* a topic branch even though it might be > doable for a small tree like slab.git. > I commented on improvements for three of the five patches you've added as slub cleanups and Christoph has shown an interest in proposing them again (perhaps seperating patches 1-5 out as a seperate set of cleanups?), so it's probably cleaner to just reset and reapply with the revisions. Let me know if my suggested changes should be add-on patches to Christoph's first five and I'll come up with a three patch series to do just that. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>