On Mon, 10 May 2010, KAMEZAWA Hiroyuki wrote: > > But, move_page_tables()'s failure is not a big problem. Well, yes and no. It's not a problem because it fails, but because it does the allocation. Which means that we can't protect the thing with the (natural) anon_vma locking. > Considering cost, as Mel shows, "don't migrate apges in exec's stack" seems > reasonable. But, I still doubt this check. Well, I actually always liked Mel's patch, the one he calls "magic". I think it's _less_ magic than the crazy "let's create another vma and anon_vma chain just because migration has it's thumb up its ass". So I never disliked that patch. I'm perfectly happy with a "don't migrate these pages at all, because they are in a half-way state in the middle of execve stack magic". Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>