On Wed, May 05, 2010 at 02:19:08PM +0200, Andrea Arcangeli wrote:
> On Tue, Apr 20, 2010 at 10:01:14PM +0100, Mel Gorman wrote:
> > + if (page) {
> > + __count_vm_event(COMPACTSUCCESS);
> > + return page;
>
> ==
> From: Andrea Arcangeli <aarcange@xxxxxxxxxx>
>
> Preempt is enabled so it must use count_vm_event.
>
> Signed-off-by: Andrea Arcangeli <aarcange@xxxxxxxxxx>
Reviewed-by: Mel Gorman <mel@xxxxxxxxx>
Andrew, this is a fix to the patch
mmcompaction-direct-compact-when-a-high-order-allocation-fails.patch
Thanks Andrea, well spotted.
> ---
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -1768,7 +1768,7 @@ __alloc_pages_direct_compact(gfp_t gfp_m
> alloc_flags, preferred_zone,
> migratetype);
> if (page) {
> - __count_vm_event(COMPACTSUCCESS);
> + count_vm_event(COMPACTSUCCESS);
> return page;
> }
>
>
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>