On Mon, 19 Apr 2010, Minchan Kim wrote: > My concern is following as. > > alloc_pages_node means any node but it has nid argument. > Why should user of alloc_pages who want to get page from any node pass > nid argument? It's rather awkward. Its not awkward but an optimization. The page can be placed on any node but the user would prefer a certain node. Most of the NUMA things are there for optimization purposes and not for correctness. If you must have an allocation on certain nodes for correctness (like SLAB) then GFP_THISNODE is used. > Some of user misunderstood it and used alloc_pages_node instead of > alloc_pages_exact_node although he already know exact _NID_. > Of course, it's not a BUG since if nid >= 0 it works well. > > But I want to remove such multiple meaning to clear intention of user. Its not clear to me that this renaming etc helps. You must use GFP_THISNODE if allocation must occur from a certain node. alloc_pages_exact_node results in more confusion because it does suggest that fallback to other nodes is not allowed. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>