Hi, Tejun. On Thu, Apr 15, 2010 at 8:39 AM, Tejun Heo <tj@xxxxxxxxxx> wrote: > Hello, > > On 04/14/2010 12:48 AM, Mel Gorman wrote: >> and the mapping table on x86 at least is based on possible CPUs in >> init_cpu_to_node() leaves the mapping as 0 if the APIC is bad or the numa >> node is reported in apicid_to_node as -1. It would appear on power that >> the node will be 0 for possible CPUs as well. >> >> Hence, I believe this to be safe but a confirmation from Tejun would be >> nice. I would continue digging but this looks like an initialisation path >> so I'll move on to the next patch rather than spending more time. > > This being a pretty cold path, I don't really see much benefit in > converting it to alloc_pages_node_exact(). It ain't gonna make any > difference. I'd rather stay with the safer / boring one unless > there's a pressing reason to convert. Actually, It's to weed out not-good API usage as well as some performance gain. But I don't think to need it strongly. Okay. Please keep in mind about this and correct it if you confirms it in future. :) > > Thanks. > > -- > tejun > -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href