On Mon, 12 Apr 2010, Linus Torvalds wrote: > > So as I already commented to Andrew, the code has no comments about the > "big picture", and the largest comment I found was about a totally > _trivial_ issue about replacing the hugepage by first clearing the entry, > then flushing the tlb, and then filling it. Btw, this is the same complaint I had about the anon_vma code. There was no overview comments, and some of my fixes to that came directly from writing a big-picture "what should happen" flow chart, and either noticing that the code didn't do what it should have done, or that even the big picture was not clear. And yes, I do realize that historically we (I) haven't been good at those things. It's just that the VM has gotten _so_ complicated that we damn well need them, at least when we add new features that the rest of the VM team doesn't know by rote. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>