On Sun, 2010-04-04 at 20:03 +0400, Evgeniy Polyakov wrote: > On Mon, Apr 05, 2010 at 12:59:44AM +0900, Minchan Kim (minchan.kim@xxxxxxxxx) wrote: > > > perusing the code in mm/filemap.c and i'm curious as to why routines > > > like, for example, add_to_page_cache_lru() are being exported. is it > > > really expected that loadable modules might access routines like that > > > directly? > > > > It is added by 18bc0bbd162e3 for pohmelfs and now used by logfs, too. > > I didn't noticed that at that time. > > With git log, any mm guys didn't add Signed-off-by or Reviewed-by. > > > > I think it's not good for file system or module to use it directly. > > It would make LRU management harder. > > How come? > > > Is it really needed? Let's think again. > > Yes, it is really needed. It is not a some king of low-level mm magic to > export, but a useful interface to work with LRU lists instead of > copy-paste it into own machinery. > -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>