On 04/02, David Rientjes wrote: > > On Fri, 2 Apr 2010, Oleg Nesterov wrote: > > > > > I prefer to keep oom_badness() to be a positive range as > > > it always has been (and /proc/pid/oom_score has always used an unsigned > > > qualifier), > > > > Yes, I thought about /proc/pid/oom_score, but imho this is minor issue. > > We can s/%lu/%ld/ though, or just report 0 if oom_badness() returns -1. > > Or something. > > Just have it return 0, meaning never kill, and then ensure "chosen" is > never set for an oom_badness() of 0, even if we don't have another task to > kill. That's how Documentation/filesystems/proc.txt describes it anyway. OK, agreed, this makes more sense and more clean. I misunderstood you even more before. Thanks, I'll redo/resend 3/4. Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>