On Mon, 2010-03-22 at 09:43 -0500, Christoph Lameter wrote: > On Fri, 19 Mar 2010, Lee Schermerhorn wrote: > > > Rename 'policy_types[]' to 'policy_modes[]' to better match the > > array contents. > > Reviewed-by: Christoph Lameter <cl@xxxxxxxxxxxxxxxxxxxx> > > Small nitpick: MPOL_MAX should be called MPOL_NR to follow vmstat.h and > mmzones.h's way of naming the n+1st element. The 'MPOL_MAX' has been there since David R [wasn't it?] created the enum. The current name shows up in user space numaif.h from the numactl package [2.0.3] as a #define of MPOL_MAX to MPOL_INTERLEAVE . I suppose we could #define it to MPOL_NR to avoid the possibility of application breakage if the enum ever makes it to the user space header. I checked numactl sources and the only use of MPOL_MAX in the package is one of the test programs. Don't know about end user apps out there in the wild, tho'. David: what do you think? Lee -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>