On Mon, 2010-03-22 at 09:40 -0500, Christoph Lameter wrote: > Just use i instead of mode? Local variables typically have short names. > "mode" sounds like a parameter. That was probably my thinking when I used 'i' for the loop variable back when I replaced the 'if-elseif' skip chain with the for loop to reuse the [then] "policy_types[]" array from mpol_to_str(). But, I then went and assigned it to the more meaningful 'mode' to carry around the rest of function. Looking at it this time around, seemed like I didn't need 2 vars, and outside of the loop, I thought 'mode' would be better--reinforcing the nomenclature. > But its just > style so ignore my comments > if you want. > Aw, would I do that? But, let's wait to see if anyone else weighs in. I'm not wedded to either one, except for the rationale, such as it is, mentioned above. Thanks for the review. Lee -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>