On Tue, 2 Mar 2010, KAMEZAWA Hiroyuki wrote: > Reviewd with refleshed mind. > > 1. mem_cgroup_oom_called should be removed. ok. > 2. I think mem_cgroup should not return -ENOMEM at charging > Then, no complicated thing in page_fault_out_of_memory(). > I'll add such changes, soom. pagefault_out_of_memory() needs to do the zone locking to prevent needlessly killing tasks when VM_FAULT_OOM races with another cpu trying to allocate pages. This has nothing to do with memcg. > 3. This patch includes too much things. please divide. > At least, please put memcg part ouf of this patch. > No, it doesn't. The patch rewrites pagefault_out_of_memory() and that includes removing a call to mem_cgroup_oom_called(), which you just agreed to removing. I'm not going to leave behind unused code anywhere in the kernel that you want to remove yourself anyway. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>