Re: [patch] mm: suppress pfn range output for zones without pages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 11 Feb 2010, Christoph Lameter wrote:

> > The output is now suppressed for zones that do not have a valid pfn
> > range.
> 
> There is a difference between zone support not compiled into the kernel
> and the zone being empty. The output so far allows me to see that support
> for a zone was compiled into the kernel but it is empty.
> 

So you want to parse this table of zone pfn ranges to determine, for 
example, whether CONFIG_HIGHMEM was enabled for i386 kernels?  That 
doesn't tell you whether its CONFIG_HIGHMEM4G or CONFIG_HIGHMEM64G, so 
it's a pretty bad way to interpret the kernel config and decide whether 
the pfn ranges are valid or not.  The only other use case would be to find 
if the values are sane when we don't have CONFIG_ZONE_DMA or 
CONFIG_ZONE_DMA32, but those typically aren't even disabled: I just sent a 
patch to the x86 maintainers to get that configuration to compile on -rc7.  

In other words, I don't think we need to be emitting kernel diagnostic 
messages for zones that are empty and unused just because they are enabled 
in the kernel config; no developer is going to care about parsing the 
usecase I showed in the changelog since ZONE_NORMAL is always defined.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]