Re: [PATCH] irqchip/irq-brcmstb-l2: Avoid saving mask on shutdown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/22/24 16:45, Thomas Gleixner wrote:
On Mon, Apr 22 2024 at 15:26, Florian Fainelli wrote:
On 4/22/24 14:29, Thomas Gleixner wrote:
+	if (save)
+		b->saved_mask = irq_reg_readl(gc, ct->regs.mask);

what's the conditional actually buying you except more complex code?

Not much this is an optimization that is simple to carry out. There can
be dozens of such L2 interrupt controllers in a given system and the
MMIO accesses start adding up eventually.

I'm impressed by saving ~12 microseconds per one dozen of interrupt
controllers on system shutdown :)

I know, right? More seriously are you willing to take that patch, should I write a better justification?
--
Florian





[Index of Archives]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux