On Mon, Apr 22 2024 at 15:26, Florian Fainelli wrote: > On 4/22/24 14:29, Thomas Gleixner wrote: >>> + if (save) >>> + b->saved_mask = irq_reg_readl(gc, ct->regs.mask); >> >> what's the conditional actually buying you except more complex code? > > Not much this is an optimization that is simple to carry out. There can > be dozens of such L2 interrupt controllers in a given system and the > MMIO accesses start adding up eventually. I'm impressed by saving ~12 microseconds per one dozen of interrupt controllers on system shutdown :)