On Fri, Mar 15, 2024 at 12:10:43PM +0800, Yongzhen Zhang wrote:
> early_tlb_init() and rb532_gpio_init() were local to file but not declared
> static, leading to error:
>
> arch/mips/rb532/prom.c:49:13: error: no previous prototype for ‘prom_setup_cmdline’ [-Werror=missing-prototypes]
> 49 | void __init prom_setup_cmdline(void)
> | ^~~~~~~~~~~~~~~~~~
> arch/mips/rb532/gpio.c:200:12: error: no previous prototype for ‘rb532_gpio_init’ [-Werror=missing-prototypes]
> 200 | int __init rb532_gpio_init(void)
> | ^~~~~~~~~~~~~~~
>
> Signed-off-by: Yongzhen Zhang <zhangyongzhen@xxxxxxxxxx>
> ---
> arch/mips/rb532/gpio.c | 2 +-
> arch/mips/rb532/prom.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/rb532/gpio.c b/arch/mips/rb532/gpio.c
> index 29c21b9d42da..ea6ebfea4a67 100644
> --- a/arch/mips/rb532/gpio.c
> +++ b/arch/mips/rb532/gpio.c
> @@ -197,7 +197,7 @@ void rb532_gpio_set_func(unsigned gpio)
> }
> EXPORT_SYMBOL(rb532_gpio_set_func);
>
> -int __init rb532_gpio_init(void)
> +static int __init rb532_gpio_init(void)
> {
> struct resource *r;
>
> diff --git a/arch/mips/rb532/prom.c b/arch/mips/rb532/prom.c
> index b11693715547..b88e89ec5894 100644
> --- a/arch/mips/rb532/prom.c
> +++ b/arch/mips/rb532/prom.c
> @@ -46,7 +46,7 @@ static inline unsigned long tag2ul(char *arg, const char *tag)
> return simple_strtoul(num, 0, 10);
> }
>
> -void __init prom_setup_cmdline(void)
> +static void __init prom_setup_cmdline(void)
> {
> static char cmd_line[COMMAND_LINE_SIZE] __initdata;
> char *cp, *board;
> --
> 2.34.1
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
