On 8.03.2024 11:44, AngeloGioacchino Del Regno wrote:
Il 07/03/24 20:04, Justin Swartz ha scritto:Add serial1 and serial2 nodes to define the existence of the MT7621's second and third UARTs. Signed-off-by: Justin Swartz <justin.swartz@xxxxxxxxxxxxxxxx> --- arch/mips/boot/dts/ralink/mt7621.dtsi | 28 +++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi index 3ad4e2343..5a89f0b8c 100644 --- a/arch/mips/boot/dts/ralink/mt7621.dtsi +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi @@ -124,6 +124,34 @@ serial0: serial@c00 { pinctrl-0 = <&uart1_pins>; }; + serial1: serial@d00 { + compatible = "ns16550a"; + reg = <0xd00 0x100>; + reg-io-width = <4>; + reg-shift = <2>; + clocks = <&sysc MT7621_CLK_UART2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SHARED 27 IRQ_TYPE_LEVEL_HIGH>; + no-loopback-test; + pinctrl-names = "default"; + pinctrl-0 = <&uart2_pins>;As already commented on patch [1/3], pin muxing is board specific. Please remove. Also, is there any reason why you can't simply use the `interrupts-extended` property instead of interrupt-parent and interrupts?
I'm looking at the documentation [1], it seems to be useful when multiple interrupt parents need to be defined on a node. I'd continue using interrupt-parent and interrupts in this case. [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/interrupt-controller/interrupts.txt Arınç
