Hello, On Wed Feb 21, 2024 at 2:45 PM CET, Linus Walleij wrote: > On Wed, Feb 14, 2024 at 5:24 PM Théo Lebrun <theo.lebrun@xxxxxxxxxxx> wrote: > > We create a custom compatible for the STA2X11 IP block as integrated > > into the Mobileye EyeQ5 platform. Its wake and alternate functions have > > been disabled, we want to avoid touching those registers. > > > > We both do: (1) early return in functions that do not support the > > platform, but with warnings, and (2) avoid calling those functions in > > the first place. > > > > We ensure that pinctrl-nomadik is not used with this STA2X11 variant. > > > > Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx> > (...) > >+ bool quirk_mbly; > > Compulsive abbreviation? I would just rename it: > > bool is_mobileye_soc; > > Nevermind the long name, it makes it crystal clear for readers > what is going on. (Rusty Russell's API naming guidelines.) > > With that changed: > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Makes complete sense. This is old heritage from my initial prototype that should have long gone disappeared. Thanks for your feedback & reviews! -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
