Hello, On Wed Feb 21, 2024 at 3:37 PM CET, Linus Walleij wrote: > just a quick note here: > > On Wed, Feb 14, 2024 at 5:24 PM Théo Lebrun <theo.lebrun@xxxxxxxxxxx> wrote: > > > +config GPIO_NOMADIK > > + bool "Nomadik GPIO driver" > > + depends on ARCH_U8500 || ARCH_NOMADIK || COMPILE_TEST > > + select OF_GPIO > > + select GPIOLIB_IRQCHIP > > Could you add: > > default PINCTRL_NOMADIK > > so it is turned on by default when we have that, since they are jitted together > so closely. Would that bring something more than what is currently present? I've set PINCTRL_NOMADIK to select GPIO_NOMADIK. This means that if PINCTRL_NOMADIK=y then GPIO_NOMADIK=y. If PINCTRL_NOMADIK=n then GPIO_NOMADIK is free to be whatever. This behavior sounds similar to what would happen if adding "default PINCTRL_NOMADIK". Thanks, -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
