On Thu, Dec 28, 2023 at 03:57:55PM +0100, Théo Lebrun wrote: > Hello, > > On Wed Dec 27, 2023 at 7:27 PM CET, Rob Herring wrote: > > On Wed, Dec 27, 2023 at 10:24 AM Théo Lebrun <theo.lebrun@xxxxxxxxxxx> wrote: > > > > > > Add documentation to describe the "Other Logic Block" syscon. > > > > > > Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx> > > > --- > > > .../bindings/soc/mobileye/mobileye,eyeq5-olb.yaml | 44 ++++++++++++++++++++++ > > > MAINTAINERS | 1 + > > > 2 files changed, 45 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml > > > new file mode 100644 > > > index 000000000000..b148a49b08f1 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml > > > @@ -0,0 +1,44 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/soc/mobileye/mobileye,eyeq5-olb.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Mobileye EyeQ5 SoC system controller > > > + > > > +maintainers: > > > + - Grégory Clement <gregory.clement@xxxxxxxxxxx> > > > + - Théo Lebrun <theo.lebrun@xxxxxxxxxxx> > > > + - Vladimir Kondratiev <vladimir.kondratiev@xxxxxxxxxxxx> > > > + > > > +description: > > > + OLB ("Other Logic Block") is a hardware block grouping smaller blocks. Clocks, > > > + resets, pinctrl are being handled from here. > > > > I don't see resets or pinctrl in the binding. Please make it complete > > whether you have the driver or not. > > > > As-is, you don't need clocks to be a child node. > > Will do. Would it make sense to have the three drivers be a single > series? You could, but doesn't have to be. Just make the binding complete. Whether you have the drivers done is up to you. > Else we could have the dt-bindings be part of the base platform > support series[1]. > > [1]: https://lore.kernel.org/lkml/20231212163459.1923041-1-gregory.clement@xxxxxxxxxxx/ > > > > +properties: > > > + compatible: > > > + items: > > > + - const: mobileye,eyeq5-olb > > > + - const: syscon > > > + - const: simple-mfd > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + reg-io-width: > > > + const: 4 > > > > Why do you need this? It is not a generic block and can only ever be 1 > > value. > > This block is still a syscon in the end. I wanted to explicit that > access width must be 4 bytes and nothing else. > > Does you question mean you think I should be removing it? Yes. It can be implied by compatible. Rob
