On Wed, Dec 27, 2023 at 10:24 AM Théo Lebrun <theo.lebrun@xxxxxxxxxxx> wrote: > > Add documentation to describe the "Other Logic Block" syscon. > > Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx> > --- > .../bindings/soc/mobileye/mobileye,eyeq5-olb.yaml | 44 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 45 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml > new file mode 100644 > index 000000000000..b148a49b08f1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/mobileye/mobileye,eyeq5-olb.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mobileye EyeQ5 SoC system controller > + > +maintainers: > + - Grégory Clement <gregory.clement@xxxxxxxxxxx> > + - Théo Lebrun <theo.lebrun@xxxxxxxxxxx> > + - Vladimir Kondratiev <vladimir.kondratiev@xxxxxxxxxxxx> > + > +description: > + OLB ("Other Logic Block") is a hardware block grouping smaller blocks. Clocks, > + resets, pinctrl are being handled from here. I don't see resets or pinctrl in the binding. Please make it complete whether you have the driver or not. As-is, you don't need clocks to be a child node. > + > +properties: > + compatible: > + items: > + - const: mobileye,eyeq5-olb > + - const: syscon > + - const: simple-mfd > + > + reg: > + maxItems: 1 > + > + reg-io-width: > + const: 4 Why do you need this? It is not a generic block and can only ever be 1 value. > + > +required: > + - compatible > + - reg > + - reg-io-width > + > +additionalProperties: false > + > +examples: > + - | > + olb@e00000 { > + compatible = "mobileye,eyeq5-olb", "syscon", "simple-mfd"; > + reg = <0xe00000 0x400>; > + reg-io-width = <4>; Make this example complete and drop the child node example. Rob