Hello, On Wed Jan 3, 2024 at 12:43 AM CET, Stephen Boyd wrote: > Quoting Théo Lebrun (2023-12-27 08:30:20) > > > > I went ahead with a V2, feeling it would be more productive to come up > > with something and gather comments on concrete stuff. There were many > > other things to address anyway. > > > > I've addressed this point by declaring a dummy fixed-clock in the > > devicetree that gets fed to the GIC timer. It is pretty much the same > > thing as using `clock-frequency` which this specific clocksource uses > > if `of_clk_get(node, 0)` fails. With the sent approach we have the > > timer appear in the clock tree as a consumer. > > > > Ok, please send another round then. I was away from my computer for a > week or two. No worries, hope you had a nice time. On Wed Jan 3, 2024 at 12:47 AM CET, Stephen Boyd wrote: > If the frequency is fixed then this seems fine to do always. It is the case. Can you confirm that the taken approach is fine for you? One issue I see with my V2 is that I still expose the timer clk from the clk driver, even though it is not consumed by anyone and it is exposed as a fixed-rate from a devicetree node. That makes a duplicate. Thanks, -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
